Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update resource_management.md #1502

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

petrkohut
Copy link
Contributor

Fixed example code snippet for setting up resources for dex.

What type of PR is this?

/kind documentation

What does this PR do / why we need it:
Fixes a bug in documentation for how to configure resources block for Dex ArgoCD component.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
None. This is such a small fix, that I create a PR directly.

How to test changes / Special notes to the reviewer:
The change can be tested by provisioning a new ArgoCD resource and checking that dex got correct resources assigned.

apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
  name: example-argocd
spec:
  sso:
    dex:
      openShiftOAuth: true
      resources:
        requests:
          cpu: 250m
          memory: 128Mi
        limits:
          cpu: 500m
          memory: 256Mi
    provider: dex
  tls:
    ca: {}

@svghadi
Copy link
Collaborator

svghadi commented Aug 7, 2024

Thanks @petrkohut for the PR. The change looks good. Can you fix the DOC check by signing the commit?

@svghadi svghadi changed the title Update resource_management.md docs: Update resource_management.md Aug 7, 2024
@petrkohut
Copy link
Contributor Author

Hey @svghadi ,
it's fixed now. Thanks!

Signed-off-by: Petr Kohut <me@petrkohut.cz>
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉 . Thanks for the contribution @petrkohut .

@svghadi svghadi merged commit 1cde103 into argoproj-labs:master Aug 8, 2024
7 checks passed
@petrkohut petrkohut deleted the patch-1 branch August 8, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants