-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade operator-sdk to 1.35.0 and migrate kubebuilder go/v3 to go/v4 #1449
chore: upgrade operator-sdk to 1.35.0 and migrate kubebuilder go/v3 to go/v4 #1449
Conversation
This PR includes the changes in #1447 which was only upgrading it to operator-sdk 1.32 With this PR, the migration from kubebuilder go/v3 to go/v4 is also added. The operator has been tested and passes with these steps as well - https://github.com/argoproj-labs/argocd-operator/tree/master/tests/olm#build-and-install-the-operator |
11fcd26
to
778b295
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @saumeya!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!!
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @saumeya
What type of PR is this?
/kind chore
What does this PR do / why we need it:
This PR upgrades the current operator to use operator-sdk 1.35 and kubebuilder go/v4.
This is needed to keep the operator up to date with the latest dependencies
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer: