Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade operator-sdk to 1.35.0 and migrate kubebuilder go/v3 to go/v4 #1449

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

saumeya
Copy link
Collaborator

@saumeya saumeya commented Jul 8, 2024

What type of PR is this?
/kind chore

What does this PR do / why we need it:

This PR upgrades the current operator to use operator-sdk 1.35 and kubebuilder go/v4.
This is needed to keep the operator up to date with the latest dependencies

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

@saumeya saumeya changed the title Upgrade to kubebuilder v4 chore: upgrade operator-sdk to 1.35.0 and migrate kubebuilder go/v3 to go/v4 Jul 9, 2024
@saumeya saumeya marked this pull request as ready for review July 9, 2024 19:25
@saumeya saumeya requested a review from svghadi July 9, 2024 19:26
@saumeya
Copy link
Collaborator Author

saumeya commented Jul 9, 2024

This PR includes the changes in #1447 which was only upgrading it to operator-sdk 1.32

With this PR, the migration from kubebuilder go/v3 to go/v4 is also added.

The operator has been tested and passes with these steps as well - https://github.com/argoproj-labs/argocd-operator/tree/master/tests/olm#build-and-install-the-operator

@saumeya saumeya mentioned this pull request Jul 9, 2024
2 tasks
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @saumeya!

Copy link
Collaborator

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!!

@anandrkskd
Copy link
Contributor

LGTM

Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @saumeya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants