feat: secure redis authentication [CVE-2024-31989] #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
svghadi
reviewed
May 20, 2024
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
svghadi
approved these changes
May 22, 2024
There was a problem hiding this comment.
Ran some manual test as well as ha kuttl test. LGTM. Thanks @iam-veeramalla
iam-veeramalla
changed the title
|
/cherry-pick release-0.10 |
|
Cherry-pick failed with |
|
/cherry-pick release-0.9 |
|
Cherry-pick failed with |
|
/cherry-pick release-0.8 |
|
Cherry-pick failed with |
|
/cherry-pick release-0.10 |
|
Cherry-pick failed with |
iam-veeramalla
added a commit
to iam-veeramalla/argocd-operator
that referenced
this pull request
May 22, 2024
* feat: secure redis authentication Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix: failing unit tests Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix: code review comments and liniting issue Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix: issues with HA pod crashing Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix: mount password env Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> --------- Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
iam-veeramalla
added a commit
to iam-veeramalla/argocd-operator
that referenced
this pull request
May 22, 2024
iam-veeramalla
added a commit
to iam-veeramalla/argocd-operator
that referenced
this pull request
May 22, 2024
iam-veeramalla
added a commit
to iam-veeramalla/argocd-operator
that referenced
this pull request
May 22, 2024
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
iam-veeramalla
added a commit
that referenced
this pull request
May 22, 2024
* feat: secure redis authentication * fix: failing unit tests * fix: code review comments and liniting issue * fix: issues with HA pod crashing * fix: mount password env --------- Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
iam-veeramalla
added a commit
that referenced
this pull request
May 22, 2024
iam-veeramalla
added a commit
that referenced
this pull request
May 22, 2024
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
svghadi
added
the
backport-to-redesign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
Fix CVE-2024-31989
It has been discovered that an unprivileged pod in a different namespace on the same cluster could connect to the Redis server on port 6379. Despite having installed the latest version of the VPC CNI plugin on the EKS cluster, it requires manual enablement through configuration to enforce network policies. This raises concerns that many clients might unknowingly have open access to their Redis servers. This vulnerability could lead to Privilege Escalation to the level of cluster controller, or to information leakage, affecting anyone who does not have strict access controls on their Redis instance. This issue has been patched in version(s) 2.8.19, 2.9.15 and 2.10.10.
Have you updated the necessary documentation?
NA
Which issue(s) this PR fixes:
Fixes CVE-2024-31989
How to test changes / Special notes to the reviewer: