-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add context to notification #1305
Merged
iam-veeramalla
merged 2 commits into
argoproj-labs:master
from
saumeya:add-context-to-notification
Apr 18, 2024
Merged
fix: add context to notification #1305
iam-veeramalla
merged 2 commits into
argoproj-labs:master
from
saumeya:add-context-to-notification
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svghadi
reviewed
Apr 18, 2024
Signed-off-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb> changes Signed-off-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb> ci failures Signed-off-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb> review comments Signed-off-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb>
saumeya
force-pushed
the
add-context-to-notification
branch
from
April 18, 2024 09:15
a6e5a2b
to
7206579
Compare
svghadi
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out the changes. Looks good.
Thanks @saumeya !!
/cherry-pick release-0.10 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
* fix: add condtext to notification Signed-off-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb> changes Signed-off-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb> ci failures Signed-off-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb> review comments Signed-off-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb> * type Signed-off-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb> --------- Signed-off-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb> Co-authored-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb>
svghadi
pushed a commit
that referenced
this pull request
Apr 26, 2024
* fix: add condtext to notification --------- Signed-off-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb> Co-authored-by: Saumeya Katyal <saumeyakatyal@gmail.com> Co-authored-by: Saumeya Katyal <skatyal@skatyal-thinkpadt14sgen1.bengluru.csb>
svghadi
added
the
backport-to-redesign
Changes which need to be backported to operator-redesign branch
label
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
To allpow users to set context in their notificationConfiguration CR
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:
make install run
notifications
enableddefault-notifications-configuration
is createdargocd-notifications-cm
, verify the context appears correctly.