Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SeccompProfile for PodSecurityStandards "restricted" to avoid Pod Security Violations on restricted namespaces #1288

Merged

Conversation

ibihim
Copy link
Contributor

@ibihim ibihim commented Mar 27, 2024

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

It is necessary to set the seccompProfile to RuntimeDefault to meet the PodSecurityStandards of restricted, which will be a common default in clusters.
Otherwise the workloads will be evaluated as baseline and rejected, if not set otherwise in the namespace metadata.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

Wrt testing:

Ideally we would set the namespace metadata.labels values for argoCD to

    pod-security.kubernetes.io/enforce: restricted
    pod-security.kubernetes.io/enforce-version: latest
    pod-security.kubernetes.io/audit: restricted
    pod-security.kubernetes.io/audit-version: latest
    pod-security.kubernetes.io/warn: restricted
    pod-security.kubernetes.io/warn-version: latest

and the workloads shouldn't fail.

Wrt special notes:
I hope I found all SecurityContext, it would be good if someone double checks this.

It is necessary to set the seccompProfile to RuntimeDefault to meet the
PodSecurityStandards of restricted, which will be a common default in
clusters.
Otherwise the workloads will be evaluated as baseline and rejected, if
not set otherwise in the namespace metadata.
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Copy link
Collaborator

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iam-veeramalla iam-veeramalla merged commit e2a991b into argoproj-labs:master Jun 6, 2024
7 checks passed
anandf pushed a commit to anandf/argocd-operator that referenced this pull request Jun 6, 2024
… Security Violations on restricted namespaces (argoproj-labs#1288)

* Add SeccompProfile for PSA restricted

It is necessary to set the seccompProfile to RuntimeDefault to meet the
PodSecurityStandards of restricted, which will be a common default in
clusters.
Otherwise the workloads will be evaluated as baseline and rejected, if
not set otherwise in the namespace metadata.

* fix: failing test

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>

---------

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
anandf added a commit that referenced this pull request Jun 7, 2024
* fix: don't change the default policy to reencrypt if the TLS secret is present (#1401)

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Add SeccompProfile for PodSecurityStandards "restricted" to avoid Pod Security Violations on restricted namespaces (#1288)

* Add SeccompProfile for PSA restricted

It is necessary to set the seccompProfile to RuntimeDefault to meet the
PodSecurityStandards of restricted, which will be a common default in
clusters.
Otherwise the workloads will be evaluated as baseline and rejected, if
not set otherwise in the namespace metadata.

* fix: failing test

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>

---------

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Rebase master with 0.10.0 and 0.9.1 releases (#1403)

* argocd-operator v0.10.0 release (#1343)

* fix typo in metadata (#1354)

* update replaces version number for 0.10.0 to 0.9.1 (#1365)

* update make deploy manifests

* rebase with 0.9.1

* fix bundle manifest control plane

* make bundle

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

---------

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Co-authored-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Co-authored-by: Krzysztof Ostrowski <krzysztof.ostrowski@posteo.de>
Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Co-authored-by: Regina Scott <50851526+reginapizza@users.noreply.github.com>
anandf added a commit to anandf/argocd-operator that referenced this pull request Jun 7, 2024
* fix: don't change the default policy to reencrypt if the TLS secret is present (argoproj-labs#1401)

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Add SeccompProfile for PodSecurityStandards "restricted" to avoid Pod Security Violations on restricted namespaces (argoproj-labs#1288)

* Add SeccompProfile for PSA restricted

It is necessary to set the seccompProfile to RuntimeDefault to meet the
PodSecurityStandards of restricted, which will be a common default in
clusters.
Otherwise the workloads will be evaluated as baseline and rejected, if
not set otherwise in the namespace metadata.

* fix: failing test

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>

---------

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Rebase master with 0.10.0 and 0.9.1 releases (argoproj-labs#1403)

* argocd-operator v0.10.0 release (argoproj-labs#1343)

* fix typo in metadata (argoproj-labs#1354)

* update replaces version number for 0.10.0 to 0.9.1 (argoproj-labs#1365)

* update make deploy manifests

* rebase with 0.9.1

* fix bundle manifest control plane

* make bundle

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

---------

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Co-authored-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Co-authored-by: Krzysztof Ostrowski <krzysztof.ostrowski@posteo.de>
Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Co-authored-by: Regina Scott <50851526+reginapizza@users.noreply.github.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
@svghadi svghadi added the backport-to-redesign Changes which need to be backported to operator-redesign branch label Jun 19, 2024
@svghadi svghadi removed the backport-to-redesign Changes which need to be backported to operator-redesign branch label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants