-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SeccompProfile for PodSecurityStandards "restricted" to avoid Pod Security Violations on restricted namespaces #1288
Merged
iam-veeramalla
merged 2 commits into
argoproj-labs:master
from
ibihim:pod-security-admission-restricted
Jun 6, 2024
Merged
Add SeccompProfile for PodSecurityStandards "restricted" to avoid Pod Security Violations on restricted namespaces #1288
iam-veeramalla
merged 2 commits into
argoproj-labs:master
from
ibihim:pod-security-admission-restricted
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is necessary to set the seccompProfile to RuntimeDefault to meet the PodSecurityStandards of restricted, which will be a common default in clusters. Otherwise the workloads will be evaluated as baseline and rejected, if not set otherwise in the namespace metadata.
ibihim
force-pushed
the
pod-security-admission-restricted
branch
from
March 27, 2024 11:28
0f689a3
to
50cb909
Compare
Merged
4 tasks
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
anandf
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
anandf
pushed a commit
to anandf/argocd-operator
that referenced
this pull request
Jun 6, 2024
… Security Violations on restricted namespaces (argoproj-labs#1288) * Add SeccompProfile for PSA restricted It is necessary to set the seccompProfile to RuntimeDefault to meet the PodSecurityStandards of restricted, which will be a common default in clusters. Otherwise the workloads will be evaluated as baseline and rejected, if not set otherwise in the namespace metadata. * fix: failing test Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> --------- Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
anandf
added a commit
that referenced
this pull request
Jun 7, 2024
* fix: don't change the default policy to reencrypt if the TLS secret is present (#1401) Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Add SeccompProfile for PodSecurityStandards "restricted" to avoid Pod Security Violations on restricted namespaces (#1288) * Add SeccompProfile for PSA restricted It is necessary to set the seccompProfile to RuntimeDefault to meet the PodSecurityStandards of restricted, which will be a common default in clusters. Otherwise the workloads will be evaluated as baseline and rejected, if not set otherwise in the namespace metadata. * fix: failing test Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> --------- Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Rebase master with 0.10.0 and 0.9.1 releases (#1403) * argocd-operator v0.10.0 release (#1343) * fix typo in metadata (#1354) * update replaces version number for 0.10.0 to 0.9.1 (#1365) * update make deploy manifests * rebase with 0.9.1 * fix bundle manifest control plane * make bundle Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> --------- Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Co-authored-by: Krzysztof Ostrowski <krzysztof.ostrowski@posteo.de> Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: Regina Scott <50851526+reginapizza@users.noreply.github.com>
anandf
added a commit
to anandf/argocd-operator
that referenced
this pull request
Jun 7, 2024
* fix: don't change the default policy to reencrypt if the TLS secret is present (argoproj-labs#1401) Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Add SeccompProfile for PodSecurityStandards "restricted" to avoid Pod Security Violations on restricted namespaces (argoproj-labs#1288) * Add SeccompProfile for PSA restricted It is necessary to set the seccompProfile to RuntimeDefault to meet the PodSecurityStandards of restricted, which will be a common default in clusters. Otherwise the workloads will be evaluated as baseline and rejected, if not set otherwise in the namespace metadata. * fix: failing test Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> --------- Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Rebase master with 0.10.0 and 0.9.1 releases (argoproj-labs#1403) * argocd-operator v0.10.0 release (argoproj-labs#1343) * fix typo in metadata (argoproj-labs#1354) * update replaces version number for 0.10.0 to 0.9.1 (argoproj-labs#1365) * update make deploy manifests * rebase with 0.9.1 * fix bundle manifest control plane * make bundle Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> --------- Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Co-authored-by: Krzysztof Ostrowski <krzysztof.ostrowski@posteo.de> Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Co-authored-by: Regina Scott <50851526+reginapizza@users.noreply.github.com> Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
svghadi
added
the
backport-to-redesign
Changes which need to be backported to operator-redesign branch
label
Jun 19, 2024
svghadi
removed
the
backport-to-redesign
Changes which need to be backported to operator-redesign branch
label
Aug 7, 2024
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
It is necessary to set the seccompProfile to RuntimeDefault to meet the PodSecurityStandards of restricted, which will be a common default in clusters.
Otherwise the workloads will be evaluated as baseline and rejected, if not set otherwise in the namespace metadata.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:
Wrt testing:
Ideally we would set the namespace
metadata.labels
values for argoCD toand the workloads shouldn't fail.
Wrt special notes:
I hope I found all
SecurityContext
, it would be good if someone double checks this.