Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update --enable-scm-providers cmd in appset deployment #1263

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

svghadi
Copy link
Collaborator

@svghadi svghadi commented Feb 22, 2024

What type of PR is this?

/kind bug

What does this PR do / why we need it:
The appset controller doesn't consider the --enable-scm-providers flag value when set as below in deployment

args:
- --enable-scm-providers
- "false"

This changes updates the flag to be in following format which is recognized by the controller

args:
- --enable-scm-providers=false

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@iam-veeramalla iam-veeramalla merged commit cf24327 into argoproj-labs:master Feb 22, 2024
7 checks passed
@svghadi svghadi deleted the appset-cmd-fix branch February 22, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants