test: Add unittest for spec.controller.Env #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehabhalodiya
force-pushed
the
env_unit_test
branch
from
bf325ad
to
7b44202
Compare
mehabhalodiya
force-pushed
the
env_unit_test
branch
from
38d35b5
to
348b200
Compare
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
mehabhalodiya
force-pushed
the
env_unit_test
branch
2 times, most recently
from
ef7e955
to
2752b66
Compare
|
I have verified locally, that this test is passing: @AdamSaleh can you please review this? |
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
mehabhalodiya
force-pushed
the
env_unit_test
branch
from
2752b66
to
c311dc8
Compare
svghadi
approved these changes
Feb 22, 2024
svghadi
changed the title
svghadi
added
the
backport-to-redesign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind code-refactoring
What does this PR do / why we need it:
We want to improve the coverage of our unit tests. This adds a new test for
spec.controller.Env.Which issue(s) this PR fixes:
Fixes: GITOPS-3220