Add containerenv unittest for appsync #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Saleh <adam@asaleh.net>
AdamSaleh
force-pushed
the
containerenv_unittest
branch
from
7fb15e8
to
95d552b
Compare
jaideepr97
pushed a commit
to jaideepr97/argocd-operator
that referenced
this pull request
Feb 14, 2024
Signed-off-by: Adam Saleh <adam@asaleh.net>
svghadi
added
the
backport-to-redesign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind code-refactoring
What does this PR do / why we need it:
We want to improve coverage of our unit-tests. This adds a new test for getArgoControllerContainerEnv in simmilar fashion to existing tests of getArgoApplicationControllerCommand.