deploy/operator_group.yaml: remove targetNamespaces #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @johanneskastl. Can you fix the DCO check by signing the commit? |
…ger supported in 0.8.0 fix argoproj-labs#1106 Signed-off-by: Johannes Kastl <git@johannes-kastl.de>
johanneskastl
force-pushed
the
20231213_fix_operatorgroup_namespace_issue
branch
from
a18138f
to
0741fc8
Compare
Done, both signed off and GPG-signed. |
svghadi
approved these changes
Feb 9, 2024
jaideepr97
pushed a commit
to jaideepr97/argocd-operator
that referenced
this pull request
Feb 13, 2024
argoproj-labs#1108) fix argoproj-labs#1106 Signed-off-by: Johannes Kastl <git@johannes-kastl.de> Co-authored-by: Johannes Kastl <kastl@b1-systems.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove
targetNamespacesindeploy/operator_group.yaml, as this is no longer supported in 0.8.0fix #1106
What type of PR is this?
(Not sure if bug or documentation?)
/kind bug
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
fixes #1106
How to test changes / Special notes to the reviewer: