Skip to content

Commit

Permalink
fix comments for linting
Browse files Browse the repository at this point in the history
  • Loading branch information
Salem Elrahal committed Jul 26, 2023
1 parent bd25db3 commit 8d45a66
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion controllers/argocd/role.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (r *ReconcileArgoCD) reconcileRole(name string, policyRules []v1.PolicyRule
}
// only skip creation of dex and redisHa roles for namespaces that no argocd instance is deployed in
if len(list.Items) < 1 {
// cr.ObjectMeta.Namespace doesn't contain argocd instance, so don't create any role that isn't the application-controller or the server
// namespace doesn't contain argocd instance, so skipe all the ArgoCD internal roles
if cr.ObjectMeta.Namespace != namespace.Name && (name != common.ArgoCDApplicationControllerComponent && name != common.ArgoCDServerComponent) {
continue
}
Expand Down
2 changes: 1 addition & 1 deletion controllers/argocd/rolebinding.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func (r *ReconcileArgoCD) reconcileRoleBinding(name string, rules []v1.PolicyRul
}
// only skip creation of dex and redisHa rolebindings for namespaces that no argocd instance is deployed in
if len(list.Items) < 1 {
// cr.ObjectMeta.Namespace doesn't contain argocd instance, so don't create any role that isn't the application-controller or the server
// namespace doesn't contain argocd instance, so skipe all the ArgoCD internal roles
if cr.ObjectMeta.Namespace != namespace.Name && (name != common.ArgoCDApplicationControllerComponent && name != common.ArgoCDServerComponent) {
continue
}
Expand Down

0 comments on commit 8d45a66

Please sign in to comment.