fix logic to allow processor operation to be less than default value (#…

…1146)

* fix logic to allow operation processors to be less than default value

---------

Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>

controllers/argocd/util.go

@@ -309,7 +309,7 @@ func (r *ReconcileArgoCD) getArgoServerURI(cr *argoproj.ArgoCD) string {
 // getArgoServerOperationProcessors will return the numeric Operation Processors value for the ArgoCD Server.
 func getArgoServerOperationProcessors(cr *argoproj.ArgoCD) int32 {
 	op := common.ArgoCDDefaultServerOperationProcessors
-	if cr.Spec.Controller.Processors.Operation > op {
+	if cr.Spec.Controller.Processors.Operation > 0 {
 		op = cr.Spec.Controller.Processors.Operation
 	}
 	return op

controllers/argocd/util_test.go

@@ -389,6 +389,48 @@ func TestGetArgoApplicationControllerCommand(t *testing.T) {
 				"text",
 			},
 		},
+		{
+			"configured operation processors to zero",
+			[]argoCDOpt{operationProcessors(0)},
+			[]string{
+				"argocd-application-controller",
+				"--operation-processors",
+				"10",
+				"--redis",
+				"argocd-redis.argocd.svc.cluster.local:6379",
+				"--repo-server",
+				"argocd-repo-server.argocd.svc.cluster.local:8081",
+				"--status-processors",
+				"20",
+				"--kubectl-parallelism-limit",
+				"10",
+				"--loglevel",
+				"info",
+				"--logformat",
+				"text",
+			},
+		},
+		{
+			"configured operation processors to be between zero and ten",
+			[]argoCDOpt{operationProcessors(5)},
+			[]string{
+				"argocd-application-controller",
+				"--operation-processors",
+				"5",
+				"--redis",
+				"argocd-redis.argocd.svc.cluster.local:6379",
+				"--repo-server",
+				"argocd-repo-server.argocd.svc.cluster.local:8081",
+				"--status-processors",
+				"20",
+				"--kubectl-parallelism-limit",
+				"10",
+				"--loglevel",
+				"info",
+				"--logformat",
+				"text",
+			},
+		},
 		{
 			"configured parallelism limit",
 			[]argoCDOpt{parallelismLimit(30)},