Add image folder to registry scanner #952
Conversation
Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #952 +/- ##
=======================================
Coverage 74.64% 74.64%
=======================================
Files 31 31
Lines 3913 3913
=======================================
Hits 2921 2921
Misses 856 856
Partials 136 136 ☔ View full report in Codecov by Sentry. |
…anner Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
ishitasequeira
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
registry-scanner/go.mod
Outdated
| @@ -1,22 +1,83 @@ | |||
| module github.com/argoproj-labs/argocd-image-updater/registry-scanner | |||
|
|
|||
| go 1.22.3 | |||
There was a problem hiding this comment.
image-updater currently has go version 1.22.0. I think they should be consistent.
registry-scanner/go.mod
Outdated
| go 1.22.3 | ||
|
|
||
| require ( | ||
| github.com/argoproj-labs/argocd-image-updater v0.15.1 |
There was a problem hiding this comment.
Will this sub-module build and work without dependency on image-updater? I think we should avoid depending on image-updater for easy consumption.
There was a problem hiding this comment.
I think I missed updating one import to the correct package leading to the addition of image-updater dependency. Updated the import to correct package and removed dependency on image-updater.
registry-scanner/go.mod
Outdated
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) | ||
|
|
||
| replace k8s.io/client-go => k8s.io/client-go v0.31.0 |
There was a problem hiding this comment.
some dependency versions are different from those in image-updater. In general, I think we should keep them in sync. Also adding this sub-module to dependabot.yaml may help a bit.
There was a problem hiding this comment.
Updated all the dependencies to be in sync and also added the package to dependabot.yaml
Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
Add image folder to registry scanner module.