Skip to content

Conversation

chengfang
Copy link
Collaborator

a summary of changes in various files:

  • go.mod:
    • go get github.com/argoproj/argo-cd/v2@v2.13.0
    • for k8s.io/api-related modules in replace section, change v0.26.11 to v0.31.0
    • go mod vendor and go mod tidy
  • go.sum: changes are generated
  • other files: changes to fit new api changes in argo-cd since 2.11.7

Signed-off-by: Cheng Fang <cfang@redhat.com>
… changes in argo-cd 2.13

Signed-off-by: Cheng Fang <cfang@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.64%. Comparing base (8a156dd) to head (6859f6a).

Files with missing lines Patch % Lines
cmd/ask_pass.go 0.00% 2 Missing ⚠️
cmd/run.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #936   +/-   ##
=======================================
  Coverage   74.64%   74.64%           
=======================================
  Files          31       31           
  Lines        3913     3913           
=======================================
  Hits         2921     2921           
  Misses        856      856           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chengfang
Copy link
Collaborator Author

chengfang commented Nov 14, 2024

the lint error seems to be a timeout. I'll upgrade golangci-lint to v1.61.0, the version used in argo-cd (#937)

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM, thanks!

@jannfis jannfis merged commit 6273814 into argoproj-labs:master Nov 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants