fix: allow the specific image platform os/arch/variant to meet the requirement for a broader image platform os/arch #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quirement for a broader image platform os/arch Signed-off-by: Cheng Fang <cfang@redhat.com>
chengfang
force-pushed
the
platform.match
branch
from
df23470
to
2e4b9c0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
+ Coverage 73.43% 73.48% +0.05%
==========================================
Files 31 31
Lines 3136 3142 +6
==========================================
+ Hits 2303 2309 +6
Misses 695 695
Partials 138 138 ☔ View full report in Codecov by Sentry. |
Tchoupinax
pushed a commit
to Tchoupinax/argocd-image-updater
that referenced
this pull request
Oct 23, 2024
…quirement for a broader image platform os/arch (argoproj-labs#858) Signed-off-by: Cheng Fang <cfang@redhat.com> Signed-off-by: Tchoupinax <corentinfiloche@hotmail.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #711
WantsPlatform()method to allow match of broader platformpkg/image/options_test.go