Use status instead of spec for determining source types #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Sovietaced
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
=======================================
Coverage 67.98% 67.98%
=======================================
Files 31 31
Lines 3124 3124
=======================================
Hits 2124 2124
Misses 856 856
Partials 144 144 ☔ View full report in Codecov by Sentry. |
chengfang
approved these changes
Jul 16, 2024
The missing tests will be addressed later. |
|
@Sovietaced thanks! |
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
…s#772) Signed-off-by: Jason Parraga <sovietaced@gmail.com> Co-authored-by: Cheng Fang <cfang@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a regression I noticed in multi source support: #636 (comment)
The old code would rely on detecting the source type based on the
statusfields which worked for us because application sets are unable to specify such fields. With the new code, the source type would always end up defaulting to the directory type which was incorrect and broke our application sets.This pull request reverts to the old behavior which should work for all cases hopefully.