Skip to content

add the ability to specify filename for helm based git write back target #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafedramzi
Copy link

@rafedramzi rafedramzi commented Nov 3, 2021

based on feature request: #287

edit:

  • the original commit was force pushed because the old one was unsigned

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2021

CLA assistant check
All committers have signed the CLA.

@rafedramzi rafedramzi force-pushed the rafedramzi-custom-filename branch from f05906c to 4a98c57 Compare November 4, 2021 16:49
Copy link

@iangard iangard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I had in mind when I opened the issue. I am not set up to run the tests but the logic looks sound and it meets the requirement

Copy link

@iangard iangard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I was looking for. THank you.

@jannfis
Copy link
Contributor

jannfis commented Dec 16, 2021

Hey, apologies for coming so late to this one! I was just thinking, that this is not specific to Helm, because it really is writing the app source YAML, just to a different path.

So, I think the write-back-target parameter name should not be helm (and not exclusively associated to applications of type Helm at all), but probably should be named app-source and work for both, Kustomize and Helm (and later on, possibly other) types of applications.

@albeldas
Copy link

Hi,

any update on this feature request? We really need it.

Thanks.

@ixxeL2097
Copy link

any update on this ? seems like it would be very nice to merge the feature but still no review

@Reyalsorik
Copy link

Reyalsorik commented Aug 21, 2023

This is what we are looking for!

An update would be greatly appreciated, thanks! 👍

@aqeelat
Copy link

aqeelat commented Feb 8, 2024

I think this was achieved in #636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants