Skip to content

Conversation

dkarpele
Copy link
Collaborator

  1. Use public images nginx and memcached to test update for the pod with 2 containers.

We can't use local docker registry for images named <ip>:<port>/<image_name>:<tag> because ArgoCD evaluates all images that starts with <ip>:<port> as the same images regardless <image_name>.

The function in ArgoCD that works wrong in this case is:

// Match returns true if the image name matches (i.e. up to the first delimiter)
func (i KustomizeImage) Match(j KustomizeImage) bool {
	delim := j.delim()
	imageName, _, _ := strings.Cut(string(i), delim)
	otherImageName, _, _ := strings.Cut(string(j), delim)
	return imageName == otherImageName
}

The question whether to fix the problem above or not is still open.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.49%. Comparing base (7e4c52a) to head (a57794d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1066   +/-   ##
=======================================
  Coverage   63.49%   63.49%           
=======================================
  Files          15       15           
  Lines        2326     2326           
=======================================
  Hits         1477     1477           
  Misses        758      758           
  Partials       91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chengfang
Copy link
Collaborator

chengfang commented Mar 13, 2025

can we configure the internal registry as the default for this test, and omit the url in deployment.yaml?

1. Use public images `nginx` and `memcached` to test update for the pod with 2 containers.
We can't use local docker registry for images named `<ip>:<port>/<image_name>:<tag>` because ArgoCD evaluates all images that starts with `<ip>:<port>` as the same images regardless <image_name>.

Signed-off-by: Denis Karpelevich <dkarpele@redhat.com>
@chengfang chengfang merged commit 44fef15 into argoproj-labs:master Mar 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants