Set up custom container registry and git server for image-updater e2e tests. #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests. 1. Update `/etc/rancher/k3s/registry.yaml` to `registries.yaml` according to https://docs.k3s.io/installation/private-registry 2. Use `nginx:git` permissions for git project root for private git server. It fixes 500 connection error. 3. Add `delete-prereqs` Makefile rule. 4. Update README.md Signed-off-by: Denis Karpelevich <dkarpele@redhat.com>
dkarpele
requested review from
jannfis,
chengfang,
pasha-codefresh and
ishitasequeira
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1061 +/- ##
=======================================
Coverage 63.63% 63.63%
=======================================
Files 15 15
Lines 2343 2343
=======================================
Hits 1491 1491
Misses 760 760
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chengfang
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/etc/rancher/k3s/registry.yamltoregistries.yamlaccording to https://docs.k3s.io/installation/private-registrynginx:gitpermissions for git project root for private git server. It fixes 500 connection error.delete-prereqsMakefile rule.