Feat/connect button updates #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladutjs
reviewed
Nov 24, 2023
| @@ -0,0 +1,5 @@ | |||
| import { Hex } from "../schemas/hexSchema" | |||
|
|
|||
| export const uint256ToBigInt = (low: Hex, high: Hex): bigint => { | |||
There was a problem hiding this comment.
we do theoretically have this in starknet.js. Do we have that dependency in packages/ui?
There was a problem hiding this comment.
we do theoretically have this in starknet.js
I couldn't find this, but I'll check again when I'll work on this pr again
Base automatically changed from
fix/restructure-project
to
feat/react-components
November 27, 2023 12:03
|
@vladutjs pr updated with tests, we should discuss for the notifications component (will be done in a followup pr) |
vladutjs
reviewed
Dec 14, 2023
| symbol: string | ||
| } | ||
|
|
||
| export function formatBalance( |
There was a problem hiding this comment.
can we use the same approach here as in argentx?
There was a problem hiding this comment.
sure, updated @vladutjs
vladutjs
approved these changes
Dec 14, 2023
vladutjs
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.