Skip to content

feat: backdrop click closes modal #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: backdrop click closes modal #218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b4329
feat: backdrop click closes modal
DaveVodrazka Jul 3, 2025
79e5699
fix: remove handleClose console log
DaveVodrazka Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/modal/Modal.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,22 @@
export let theme: Theme = "dark"
export let darkModeControlClass = (theme === "dark" ? "dark" : "") as Theme

const handleClose = () => {
nodeRef?.parentNode?.removeChild(nodeRef)
}

function handleKeyDown(e: KeyboardEvent) {
if (e.key === 'Escape') {
handleClose();
}
}

// close modal if user presses ESC key
onMount(() => {
window.addEventListener('keydown', handleKeyDown);
return () => window.removeEventListener('keydown', handleKeyDown);
});

onMount(async () => {
if (
theme === "dark" ||
Expand Down Expand Up @@ -111,18 +127,29 @@
bind:this={nodeRef}
part="starknetkit-modal"
class={`${darkModeControlClass} modal-font fixed inset-0 z-[9998] flex items-center justify-center backdrop-blur-sm bg-black/25`}
{...{/* on backdrop click, close the modal */}}
on:click={handleClose}
{...{/* this is for accessibility purposes */}}
on:keydown={(e) => (e.key === 'Enter' || e.key === ' ') && handleClose()}
tabindex="0"
role="button"
aria-label="Close modal by clicking the backdrop"
>
<!-- on:click|stopPropagation is not interactive, it is safe to disable a11y check -->
<!-- svelte-ignore a11y-no-noninteractive-element-interactions -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<main
role="dialog"
class={`
rounded-3xl bg-surface-default shadow-modal dark:shadow-none flex flex-col
z-[9999] w-full max-w-[380px] mx-6 p-6 text-center gap-8
z-[9999] w-full max-w-[380px] mx-6 p-6 text-center gap-8 cursor-default
${layout !== Layout.walletList ? "min-h-[570px]" : ""}
`}
on:click|stopPropagation
>
<Header
handleBack={() => setLayout(Layout.walletList)}
handleClose={() => nodeRef?.parentNode?.removeChild(nodeRef)}
handleClose={handleClose}
title={dappName}
showBackButton={showBackButton &&
![Layout.walletList, Layout.success].includes(layout)}
Expand Down