Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
- beta-braavos-mobile
- beta-argent-ww-iframe
- beta-wallet-account
- beta-connect-silent
- hotfix\/v[0-9]+.[0-9]+.[0-9]+

jobs:
Expand Down
4 changes: 4 additions & 0 deletions .releaserc
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
{
"name": "beta-argent-ww-iframe",
"prerelease": true
},
{
"name": "beta-connect-silent",
"prerelease": true
}
],
"plugins": [
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "starknetkit",
"version": "2.10.4",
"version": "2.10.5-beta-connect-silent.2",
"repository": "github:argentlabs/starknetkit",
"private": false,
"browser": {
Expand Down
5 changes: 3 additions & 2 deletions src/connectors/connector.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import EventEmitter from "eventemitter3"
import {
AccountInterface,
ProviderInterface,
type AccountInterface,
type ProviderInterface,
type ProviderOptions,
} from "starknet"
import type {
Expand Down Expand Up @@ -34,6 +34,7 @@ export interface ConnectorEvents {

export type ConnectArgs = {
chainIdHint?: bigint
silent_mode?: boolean
}

export abstract class Connector extends EventEmitter<ConnectorEvents> {
Expand Down
1 change: 1 addition & 0 deletions src/connectors/injected/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ export class InjectedConnector extends Connector {
try {
accounts = await this.request({
type: "wallet_requestAccounts",
params: { silent_mode: _args.silent_mode },
})
} catch {
throw new UserRejectedRequestError()
Expand Down
9 changes: 6 additions & 3 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import type { DisconnectOptions } from "@starknet-io/get-starknet"
import sn from "@starknet-io/get-starknet-core"
import type { StarknetWindowObject } from "@starknet-io/types-js"
import {
Connector,
StarknetkitConnector,
type Connector,
type StarknetkitConnector,
type ConnectorData,
} from "./connectors"
import { DEFAULT_WEBWALLET_URL } from "./connectors/webwallet/constants"
Expand Down Expand Up @@ -83,7 +83,10 @@ export const connect = async ({
let connectorData: ConnectorData | null = null

if (connector && resultType === "wallet") {
connectorData = await connector.connect()
// Only ArgentX connector will use silent_mode param to avoid breaking changes on other wallets
connectorData = await connector.connect({
silent_mode: connector.id === "argentX",
})
}

return {
Expand Down