fix: connectSilent method for injected connector #206
Conversation
src/connectors/injected/index.ts
Outdated
| // TODO: Temp method to connect silently, only available with StarknetkitConnector | ||
| // it's a copy of the connect method with the silent_mode set to true | ||
| // this is done to keep compatibility with starknet-react and solve an issue with a locked ArgentX wallet | ||
| async connectSilent(): Promise<ConnectorData> { |
There was a problem hiding this comment.
Why not just silent added as an optional argument to the plain connect? I don't think there will be any type issues w snreact
There was a problem hiding this comment.
that was my initial suggestion as well. do-able?
There was a problem hiding this comment.
Why not just silent added as an optional argument to the plain connect? I don't think there will be any type issues w snreact
I actually had typescript issues last time we added it (different params in the connect method compared to snreact), that was the reason to do this new method (otherwise they would need to cast as any)
I will try again this afternoon (locally) just to double check
There was a problem hiding this comment.
I don't remember having any type issues when I was testing one button connector, and I added showQrOnly or something similar to Argent's mobile connector. It could be that I'm wrong.
3 participants
Issue / feature description
Add connectSilent for
StarknetkitConnectorChanges
connectSilentthat usessilent_mode: trueconnectinmain.tsonly for argent-x to solve an issue discovered on starkgateChecklist
Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.
Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.