Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recovery phrase UI displays 'i' identically to 'l' #1989

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Recovery phrase UI displays 'i' identically to 'l' #1989

wants to merge 1 commit into from

Commits on Apr 1, 2023

  1. Recovery phrase UI displays 'i' identically to 'l' 

    On Ubuntu 22.04, using FireFox, the ArgentX wallet's font-weight for seed phrase recovery words displays the letter 'i' identically to the letter 'l'

With recovery seed phrases, it is paramount that each word is displayed clearly and unambiguously so that unscrupulous users do not write down a misspelling, rendering their recovery phrase incorrect. There exist words where this font-weight can result in ambiguous output, such as 'fail' != 'fall' 

For example, here is a screenshot from an ArgentX recovery phrase containing the word 'sail':
file:///home/robriks/Pictures/Screenshots/argentxfont.png

Thankfully I recognized that 'sall' is not a word. Setting font-weight to 500 should resolve this.
    @robriks
    robriks authored Apr 1, 2023
    Configuration menu
    Copy the full SHA
    b6ca169 View commit details
    Browse the repository at this point in the history