Code coverage improvements (TokenPriceProvider and base contracts). Disabling the KyberNetwork #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenadimitrova
force-pushed
the
maintenance/code-coverage-improvements
branch
3 times, most recently
from
7bee37e
to
ad6a2a3
Compare
elenadimitrova
changed the title
elenadimitrova
force-pushed
the
maintenance/code-coverage-improvements
branch
from
ad6a2a3
to
86cedd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring code coverage for
OwnedandManagedcontracts to 100%.Add
TokenPriceProvidertests and ensure the KyberNetwork is disabled on it to prepare for decommissioning the sync methods with that.