Compound Filter #209
Compound Filter #209
Conversation
|
|
||
| import "./IFilter.sol"; | ||
|
|
||
| contract CompoundFilter is IFilter { |
There was a problem hiding this comment.
It seems to me that the only method that needs to be forbidden is repayBorrowBehalf. Everything else is safe to allow (note that ERC20 methods of cToken will be caught in recoverSpender and do not need to be forbidden here). In particular why not allow borrow, repayBorrow, redeemUnderlying?
There was a problem hiding this comment.
Agreed for the CToken methods, we should only block reapyBorrowBehalf.
However I believe ERC20 token methods where the spender is the cToken (i.e. the ones which will end up in the filter) must be blocked because you want to prevent e.g. a transfer of DAI to cBAT. So dai.transfer(cBAT, 1000) must be blocked. The only one we should accept is an approve on the underlying to allow minting, i.e. dai.approve(cDAI,1000) .
|
|
||
| function isValid(address _wallet, address _spender, address _to, bytes calldata _data) external view override returns (bool) { | ||
| // disable ETH transfer | ||
| if (_data.length < 4) { |
There was a problem hiding this comment.
We could create the filter with a constructor parameter indicating whether this is a cErc20 or a cEther. For a cEther filter, it would be nice to enable ETH transfers (which invoke cEther's fallback) to enable deposits via simple ETH transfers.
juniset
force-pushed
the
minimal-wallet/compound
branch
from
e43dddd
to
fe312cc
Compare
This PR adds support for lending with Compound by: