Make ENS label optional in the wallet factory #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juniset
changed the title
elenadimitrova
approved these changes
Jul 16, 2020
test/factory.js
Outdated
| const tx = await factory.from(infrastructure).createWallet(owner.address, modules, NO_ENS, guardian.address); | ||
| const txReceipt = await factory.verboseWaitForTransaction(tx); | ||
| const walletAddr = txReceipt.events.filter((event) => event.event === "WalletCreated")[0].args.wallet; | ||
| assert.notEqual(walletAddr, ZERO_ADDRESS, "wallet shoudl be created"); |
juniset
force-pushed
the
feature/optional_ens_in_factory
branch
from
da0026e
to
bf18da9
Compare
elenadimitrova
force-pushed
the
feature/optional_ens_in_factory
branch
from
bf18da9
to
f00ca2a
Compare
olivdb
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make the ENS label optional when creating a wallet. If the
_labelparameter ofcreateWalletorcreateCounterfactualWalletis empty the wallet is created without an ENS. The ENS can be registered later.