Remove obsolete Compound imports #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juniset
reviewed
May 6, 2020
| } | ||
| return (0,0); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why are you removing all the Loan logic from CompoundManager? While it is not implemented in the clients yet it should still be on the roadmap. Since this code has been audited and we are still planning to use it at some point I don't see why we should remove it from the contract now.
elenadimitrova
force-pushed
the
maintenance/remove-obsolete-compound-imports
branch
from
abcef61
to
ab56541
Compare
|
The |
…ant and used there
elenadimitrova
force-pushed
the
maintenance/remove-obsolete-compound-imports
branch
from
ab56541
to
6002414
Compare
juniset
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
InvestandLoancontract dependencies from the Compound module.Here we also move the
/basecontracts folder under/infrastructurefolder as they're only relevant and used there.