Skip to content

Commit

Permalink
addressing more review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
juniset committed Apr 7, 2020
1 parent 6767c92 commit e3587fc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion deployment/1_setup_test_environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ const deploy = async (network) => {

const { configurator } = manager;
const { deployer } = manager;
const { gasPrice } = deployer.defaultOverrides;

const { config } = configurator;

Expand All @@ -77,7 +78,7 @@ const deploy = async (network) => {
const UniswapFactoryWrapper = await deployer.deploy(UniswapFactory);
configurator.updateUniswapFactory(UniswapFactoryWrapper.contractAddress);
const UniswapExchangeTemplateWrapper = await deployer.deploy(UniswapExchange);
const initializeFactoryTx = await UniswapFactoryWrapper.initializeFactory(UniswapExchangeTemplateWrapper.contractAddress);
const initializeFactoryTx = await UniswapFactoryWrapper.contract.initializeFactory(UniswapExchangeTemplateWrapper.contractAddress, { gasPrice });
await UniswapFactoryWrapper.verboseWaitForTransaction(initializeFactoryTx, "Initializing UniswapFactory");
}

Expand Down
8 changes: 4 additions & 4 deletions deployment/7_upgrade_1_6.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ const deploy = async (network) => {
const MakerRegistryWrapper = await deployer.deploy(MakerRegistry);
const ScdMcdMigrationWrapper = await deployer.wrapDeployedContract(ScdMcdMigration, config.defi.maker.migration);
const wethJoinAddress = await ScdMcdMigrationWrapper.wethJoin();
const addCollateralTransaction = await MakerRegistryWrapper.addCollateral(wethJoinAddress);
const addCollateralTransaction = await MakerRegistryWrapper.contract.addCollateral(wethJoinAddress, { gasPrice });
await MakerRegistryWrapper.verboseWaitForTransaction(addCollateralTransaction, `Adding join adapter ${wethJoinAddress} to the MakerRegistry`);
const changeMakerRegistryOwnerTx = await MakerRegistryWrapper.changeOwner(config.contracts.MultiSigWallet);
const changeMakerRegistryOwnerTx = await MakerRegistryWrapper.contract.changeOwner(config.contracts.MultiSigWallet, { gasPrice });
await MakerRegistryWrapper.verboseWaitForTransaction(changeMakerRegistryOwnerTx, "Set the MultiSig as the owner of the MakerRegistry");

// //////////////////////////////////
Expand Down Expand Up @@ -155,10 +155,10 @@ const deploy = async (network) => {
// Change the owner of TokenPriceProvider
// ////////////////////////////////////////////////////

const TokenPriceProviderRevokeManagerTx = await TokenPriceProviderWrapper.contract.revokeManager(deploymentWallet.address);
const TokenPriceProviderRevokeManagerTx = await TokenPriceProviderWrapper.contract.revokeManager(deploymentWallet.address, { gasPrice });
await TokenPriceProviderWrapper.verboseWaitForTransaction(TokenPriceProviderRevokeManagerTx,
`Revoke ${deploymentWallet.address} as the manager of the TokenPriceProvider`);
const changeOwnerTx = await TokenPriceProviderWrapper.contract.changeOwner(config.contracts.MultiSigWallet);
const changeOwnerTx = await TokenPriceProviderWrapper.contract.changeOwner(config.contracts.MultiSigWallet, { gasPrice });
await TokenPriceProviderWrapper.verboseWaitForTransaction(changeOwnerTx, "Set the MultiSig as the owner of TokenPriceProvider");

// //////////////////////////////////
Expand Down

0 comments on commit e3587fc

Please sign in to comment.