Completely refactored and changed after latest Teddy's release (0.2.0) #37

andrewryh · 2020-01-28T16:10:49Z

Summary of changes

Saltproc after refactoring, implementing non-ideal poison removal, adjustable geometry, variable depletion step. Also introduces documentation, CITATION document

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

Associated Issues and PRs

Associated Developers

Dev: @andrewryh @katyhuff

… added

…on added

…include), copy this file to iterative "iter_matfile" and store this file path and name.

Update simulation.py

…ble format added

gwenchee

Good job with documentation in the main functions! It was very clear.

A couple of comments:

Add more description of what each file's purpose is to the start of all .ini files, tap_test_00 files, .json files, .input files
Remove random commented code from all files in saltproc/data directory
Make all python files pep8 compatible
Add documentation for all python test_* functions.

.gitignore

.travis.yml

README.md

examples/di_graph_bypass.dot

examples/geometry/1070.ini

saltproc/tests/test_process.py

saltproc/tests/test_simulation.py

...sors/generate_depletion_intervals_and_power_levels/create_cumulative_time_and_power_input.py

andrewryh · 2020-01-29T16:51:36Z

Remove random commented code from all files in saltproc/data directory

Done! Commit 4784239

Make all python files pep8 compatible

They are! PEP8 did not find any issues. Surround top-level function and class definitions with two blank lines. See here: https://www.python.org/dev/peps/pep-0008/

Add documentation for all python test_* functions.

Good idea! See issue #39. This is not very sensitive problem, so, I going to do it later.

Co-Authored-By: Gwendolyn Chee <gwendolynchee95@gmail.com>

…develop

smpark7

After the latest commits, the saltproc example and tests ran successfully on my machine.

andrewryh · 2020-01-29T21:09:40Z

@gwenchee I addressed most of your comments. Please, check it out.

gwenchee

Looks good to me! Good job shortening the README

andrewryh · 2020-01-31T16:39:29Z

Looks good to me! Good job shortening the README

Thank you!

We all will take another look during the review meeting on Wed, Feb 5th, 2-4 pm, and, hopefully, will merge it!

Thank you, everyone, for your effort!

Andrei Rykhlevskii and others added 30 commits June 29, 2018 10:37

+1 in counter added after testing on BW

f9fa368

Merge branch 'master' of https://github.com/arfc/saltproc

6b32142

Simulation class has been added in separate file

b9a1c25

Material flow class moved in separated file

0c1d7b4

Depletion code mother class for SERPENT and then probably other codes…

9f95b5f

… added

Reactor class added

fbf32a8

class Process partially ready

39b27bb

class Process() finished

ef7c7ff

Serpent running function added

7752164

Simulation parameters (neutron pop, etc) checking and changing functi…

9b79d1e

…on added

Add function to check existence of Serpent file with materials (from …

9e51f53

…include), copy this file to iterative "iter_matfile" and store this file path and name.

Abs or relative path can be used in <include "mat_file"> statement

6fb7ff5

Print message when depletion code running

0070074

Depletion function finished

d55ee36

Simulation class --> runsimulation method added

6fdd526

Update simulation.py

5d52b66

Merge pull request #1 from katyhuff/patch-1

f7c851e

Update simulation.py

Passing depcode into Simulation added

94688f2

Read bumat started

4f73d3d

Read bumat file works well. Two formats of nuc_code unresolved yet

e57f659

Function for converting nuclide code in Serpent format to human reada…

7be6e53

…ble format added

Order in dictionary with depletion information from bumat preserved now

1b8ba3b

Structure materials description transfered to main input file

85e86ba

Write material file from dictionary function finished

ddd57e8

Initialization of HDF5 and dump dict to HDF5

1fa1b3b

Storing in HDF5 added

65bf38c

Keff storing in HDF5 added

ef3a333

Storing exe_time, fission mass, BR, etc in HDF5 added

39a9a66

Store mass density in HDF5 instead of number density (x vol to get mass)

bc8b775

Burnup and fission_mass stored in HDF5

9f34806

gwenchee requested changes Jan 28, 2020

View reviewed changes

andrewryh added 2 commits January 28, 2020 15:48

Addresses Sun Myung comment about Serpent must be 2.1.31 or newer.

e6a95de

Address Ansh comments. And Gwen comment #2

4784239

This was referenced Jan 29, 2020

The tap_main.json example file fails to run due to filepath issues. #38

Closed

Add documentation for all python test_* functions #39

Open

Two words file

e3ca0d7

Co-Authored-By: Gwendolyn Chee <gwendolynchee95@gmail.com>

This was referenced Jan 29, 2020

Add docs to continuous integration #35

Closed

Set up continuous integration for salt proc #26

Closed

andrewryh added 5 commits January 29, 2020 11:09

Addresses Gwen comment on power curver generation script

ca506b8

Merge branch 'develop' of https://github.com/andrewryh/saltproc into …

447cb00

…develop

Typos in DOT files fixed. More description in comments section

703254b

Duplicated DOT file removed. Fixed comments section

3d82f0d

Fixes issue with non-existed data directory

2f942c1

smpark7 approved these changes Jan 29, 2020

View reviewed changes

andrewryh added 4 commits January 29, 2020 12:31

Test clean Serpent output files after itself

69f60b2

Extra information added to TAP geometry files

4ff8576

README updated. CONTRIBUTING added. Documentation updated

b4ace94

Intallation page updated

72603f5

andrewryh added 2 commits January 30, 2020 12:28

Better look for printet paths

34c4689

User-defined momement in time when to switch to next geometry

6414571

andrewryh requested a review from gwenchee January 30, 2020 20:09

gwenchee approved these changes Jan 31, 2020

View reviewed changes

andrewryh added 3 commits January 31, 2020 11:38

Fixed wrong phrase in README

78b3b95

Back to switching geometry based on predicted keff value

80a31c8

Cleaned extra files in example

c1758d5

andrewryh merged commit 4c53f56 into arfc:master Feb 5, 2020

yardasol removed the Status:5-In Review label Dec 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Completely refactored and changed after latest Teddy's release (0.2.0) #37

Completely refactored and changed after latest Teddy's release (0.2.0) #37

andrewryh commented Jan 28, 2020 •

edited

Loading

gwenchee left a comment •

edited

Loading

andrewryh commented Jan 29, 2020 •

edited

Loading

smpark7 left a comment

andrewryh commented Jan 29, 2020

gwenchee left a comment •

edited

Loading

andrewryh commented Jan 31, 2020

Completely refactored and changed after latest Teddy's release (0.2.0) #37

Completely refactored and changed after latest Teddy's release (0.2.0) #37

Conversation

andrewryh commented Jan 28, 2020 • edited Loading

Summary of changes

Types of changes

Associated Issues and PRs

Associated Developers

gwenchee left a comment • edited Loading

Choose a reason for hiding this comment

andrewryh commented Jan 29, 2020 • edited Loading

smpark7 left a comment

Choose a reason for hiding this comment

andrewryh commented Jan 29, 2020

gwenchee left a comment • edited Loading

Choose a reason for hiding this comment

andrewryh commented Jan 31, 2020

andrewryh commented Jan 28, 2020 •

edited

Loading

gwenchee left a comment •

edited

Loading

andrewryh commented Jan 29, 2020 •

edited

Loading

gwenchee left a comment •

edited

Loading