Skip to content

Tentative class structure for discussion, second #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

andrewryh
Copy link
Contributor

Sorry, I have removed my fork, hence, I cannot push changes into PR #1.

@andrewryh andrewryh self-assigned this Oct 4, 2017
@andrewryh andrewryh requested a review from katyhuff October 4, 2017 14:28
@pep8speaks
Copy link
Contributor

Hello @andrewryh! Thanks for submitting the PR.

Line 10:5: E112 expected an indented block
Line 10:5: E301 expected 1 blank line, found 0
Line 10:27: E211 whitespace before '('
Line 11:5: E112 expected an indented block
Line 11:5: E301 expected 1 blank line, found 0
Line 11:28: E211 whitespace before '('
Line 11:80: E501 line too long (139 > 79 characters)
Line 13:1: E112 expected an indented block
Line 13:1: E302 expected 2 blank lines, found 1
Line 14:31: E211 whitespace before '('
Line 14:47: E262 inline comment should start with '# '
Line 14:80: E501 line too long (101 > 79 characters)
Line 15:5: E112 expected an indented block
Line 15:5: E301 expected 1 blank line, found 0
Line 15:13: E211 whitespace before '('
Line 15:40: E262 inline comment should start with '# '
Line 15:80: E501 line too long (133 > 79 characters)
Line 16:5: E112 expected an indented block
Line 16:5: E301 expected 1 blank line, found 0
Line 16:17: E211 whitespace before '('
Line 16:40: E262 inline comment should start with '# '
Line 17:5: E112 expected an indented block
Line 17:5: E301 expected 1 blank line, found 0
Line 17:22: E211 whitespace before '('
Line 18:5: E112 expected an indented block
Line 18:5: E301 expected 1 blank line, found 0
Line 18:52: E211 whitespace before '('
Line 20:1: E112 expected an indented block
Line 20:1: E302 expected 2 blank lines, found 1
Line 20:6: E271 multiple spaces after keyword
Line 23:1: E112 expected an indented block
Line 23:1: E302 expected 2 blank lines, found 1
Line 23:6: E271 multiple spaces after keyword
Line 25:5: E112 expected an indented block
Line 25:5: E301 expected 1 blank line, found 0
Line 26:5: E112 expected an indented block
Line 26:5: E301 expected 1 blank line, found 0
Line 34:1: W391 blank line at end of file

@katyhuff katyhuff merged commit f2b61fd into arfc:master Oct 5, 2017
andrewryh pushed a commit that referenced this pull request Jul 25, 2018
anshchaube pushed a commit that referenced this pull request Jan 29, 2020
andrewryh added a commit that referenced this pull request Feb 5, 2020
andrewryh pushed a commit that referenced this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants