-
Notifications
You must be signed in to change notification settings - Fork 3
Improvements to file generation methods, file templates, and a new universal templater function #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'm also going to @PeterCannon10 - I think this is a bit much for your first PR, but since you'll be working with Ghastly, I'm pinging you so you can take a look, if you would like. |
Peter wants to re-review -- accidental approve button mash.
|
No worries - I'm also going to tag Megan, once I figure out her username. I'll require an approval from a more senior ARFC member before merging, so don't stress too much about having your review be perfect. If you end up only asking questions about how things work, that's fine by me. You can also always come in and ask questions in person, or in the undergrad slack. |
Summary of changes
This PR is an improvement to the auto-generated file templates and templating methods used in Ghastly. It also sets up the template directory to be better organized by organizing templates for LAMMPS into a new lammps/ directory inside the templates folder.
I added a _templater() function, which renders a file using the provided dict and template. While updating the functions to use the generic _templater, I found some opportunities to simplify file generation, and as a result, some functions were no longer needed, and have been removed.
Types of changes
Associated Issues and PRs
Checklist for Reviewers
Reviewers should use this link to get to the
Review Checklist before they begin their review.