Skip to content

Commit

Permalink
make 2048 DHE key optional in intermediate level
Browse files Browse the repository at this point in the history
  • Loading branch information
jvehent committed Oct 18, 2014
1 parent ebf4f8b commit a17cfe3
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions analyze.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ def is_intermediate(results):
if conn['pfs'] != 'None':
if not has_good_pfs(conn['pfs'], 2048, 256):
logging.debug(conn['pfs']+ ' is not a good PFS parameter for the intermediate configuration')
inter = False
has_pfs = False
if conn['ocsp_stapling'] == 'False':
has_ocsp = False
Expand All @@ -200,8 +199,7 @@ def is_intermediate(results):
if not has_sha256:
failures[lvl].append("consider using a SHA-256 certificate")
if not has_pfs:
failures[lvl].append("use DHE of at least 2048bits and ECC or at least 256bits")
inter = False
failures[lvl].append("consider using DHE of at least 2048bits and ECC of at least 256bits")
if not has_ocsp:
failures[lvl].append("consider enabling OCSP Stapling")
if results['serverside'] != 'True':
Expand Down Expand Up @@ -249,7 +247,7 @@ def is_modern(results):
failures[lvl].append("use a SHA-256 certificate")
modern = False
if not has_pfs:
failures[lvl].append("use DHE of at least 2048bits and ECC or at least 256bits")
failures[lvl].append("use DHE of at least 2048bits and ECC of at least 256bits")
modern = False
if not has_ocsp:
failures[lvl].append("consider enabling OCSP Stapling")
Expand Down Expand Up @@ -352,7 +350,7 @@ def process_results(data, level=None, do_json=False):
return True

if len(failures['fubar']) > 0:
print("\nThings that are really FUBAR:")
print("\nThings that are bad:")
for failure in failures['fubar']:
print("* " + failure)

Expand Down

0 comments on commit a17cfe3

Please sign in to comment.