Skip to content

Conversation

Staars
Copy link
Contributor

@Staars Staars commented Feb 2, 2024

Description:

The following inlined function will be removed with commit espressif/arduino-esp32#8817:

    inline size_t write(const char * s)
    {
        return write((uint8_t*) s, strlen(s));
    }

To fix compilation in the future we just use the very same code in our driver.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit c24c0a5 into arendst:development Feb 2, 2024
@Staars Staars deleted the patch-1 branch July 14, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants