Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix on undef TIMERS #20123

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix on undef TIMERS #20123

merged 1 commit into from
Nov 30, 2023

Conversation

stefanbode
Copy link
Contributor

@stefanbode stefanbode commented Nov 29, 2023

fix compilation error

Description:

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

fix compilation error
stefanbode referenced this pull request Nov 29, 2023
* Fix compile issue with rules and startup procedure of deepsleep

* fix

* fix inc with old functionality

fix a side effect with the old behavior
@stefanbode
Copy link
Contributor Author

Confirmed that all builds from @Jason2866 are working now. Ready to submit.

@arendst arendst merged commit 9a010bd into arendst:development Nov 30, 2023
64 checks passed
@stefanbode stefanbode deleted the patch-18 branch November 30, 2023 08:24
@Jason2866
Copy link
Collaborator

Jason2866 commented Dec 1, 2023

@stefanbode Nearly. Still compile errors when scripter is enabled

Linking .pio/build/tasmota-titanium/firmware.elf
/home/runner/.platformio/packages/toolchain-xtensa/bin/../lib/gcc/xtensa-lx106-elf/4.8.2/../../../../xtensa-lx106-elf/bin/ld: .pio/build/tasmota-titanium/src/tasmota.ino.cpp.o:(.text._Z16DeepSleepEnabledv+0x8): undefined reference to `GetRule(unsigned int)'
/home/runner/.platformio/packages/toolchain-xtensa/bin/../lib/gcc/xtensa-lx106-elf/4.8.2/../../../../xtensa-lx106-elf/bin/ld: .pio/build/tasmota-titanium/src/tasmota.ino.cpp.o:(.text._Z16DeepSleepEnabledv+0x1f): undefined reference to `GetRule(unsigned int)'

@stefanbode
Copy link
Contributor Author

Ok, fix submitted. I do not understand why my checks on titanium, and so on all worked. Anyhow. Lets hope this was the last change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants