RavenDB-7070 Throwing NotSupportedInCoraxException instead of NotSupp…

…ortedException when unsupported feature is Corax specifc
arekpalinski · Sep 11, 2023 · d12a7d5 · d12a7d5
1 parent 94907cb
commit d12a7d5
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 10 deletions.
diff --git a/src/Raven.Server/Documents/Indexes/Persistence/Corax/AnonymousCoraxDocumentConverter.cs b/src/Raven.Server/Documents/Indexes/Persistence/Corax/AnonymousCoraxDocumentConverter.cs
@@ -3,6 +3,7 @@
 using System.Globalization;
 using Amazon.SimpleNotificationService.Model;
 using Raven.Client.Documents.Indexes;
+using Raven.Client.Exceptions.Corax;
 using Raven.Server.Documents.Indexes.Persistence.Lucene.Documents;
 using Sparrow.Json;
 using Sparrow.Json.Parsing;
@@ -105,7 +106,7 @@ void HandleCompoundFields()
             {
                 var fields = CompoundFields[i];
                 if (fields.Length != 2)
-                    throw new NotSupportedException("Currently compound indexes are only supporting exactly 2 fields");
+                    throw new NotSupportedInCoraxException("Currently compound indexes are only supporting exactly 2 fields");
 
                 var firstValueLen = AppendFieldValue(fields[0], 0);
                 var totalLen = AppendFieldValue(fields[1], firstValueLen);

diff --git a/src/Raven.Server/Documents/Indexes/Persistence/Corax/CoraxDocumentConverterBase.cs b/src/Raven.Server/Documents/Indexes/Persistence/Corax/CoraxDocumentConverterBase.cs
@@ -95,7 +95,7 @@ protected CoraxDocumentConverterBase(Index index, bool storeValue, bool indexImp
             {
                 if (compoundField.Length != 2)
                 {
-                    throw new NotSupportedException("CompoundField must have exactly 2 elements, but got: " + string.Join(",", compoundField));
+                    throw new NotSupportedInCoraxException("CompoundField must have exactly 2 elements, but got: " + string.Join(",", compoundField));
                 }
             }
         }
@@ -359,7 +359,7 @@ protected void InsertRegularField<TBuilder>(IndexField field, object value, Json
                 builder.WriteNull(fieldId, path);
                 break;
             case ValueType.BoostedValue:
-                throw new NotSupportedException("Boosting in index is not supported by Corax. You can do it during querying or change index type into Lucene.");
+                throw new NotSupportedInCoraxException("Boosting in index is not supported by Corax. You can do it during querying or change index type into Lucene.");
             case ValueType.EmptyString:
                 builder.Write(fieldId, path, ReadOnlySpan<byte>.Empty);
                 break;
@@ -376,7 +376,7 @@ protected void InsertRegularField<TBuilder>(IndexField field, object value, Json
             case ValueType.Stream:
                 throw new NotImplementedInCoraxException($"Streams are not implemented in Corax yet");
             case ValueType.Lucene:
-                throw new NotSupportedException("The Lucene value type is not supported by Corax. You can change index type into Lucene.");
+                throw new NotSupportedInCoraxException("The Lucene value type is not supported by Corax. You can change index type into Lucene.");
             default:
                 throw new NotSupportedException(valueType + " is not a supported type for indexing");
         }
@@ -469,7 +469,7 @@ internal static void ThrowIndexingComplexObjectNotSupported(IndexField field, In
             exceptionMessage =
                 $"The value of '{fieldName}' field is a complex object. Indexing it as a text isn't supported. You should consider querying on individual fields of that object.";
         }
-        throw new NotSupportedException(exceptionMessage);
+        throw new NotSupportedInCoraxException(exceptionMessage);
     }
 
     public override void Dispose()

diff --git a/src/Raven.Server/Documents/Indexes/Persistence/Corax/CoraxIndexReadOperation.cs b/src/Raven.Server/Documents/Indexes/Persistence/Corax/CoraxIndexReadOperation.cs
@@ -307,7 +307,7 @@ public Dictionary<string, Dictionary<string, string[]>> Execute(IndexQueryServer
 
 
                             if (tokensDictionary.TryGetValue(key, out var existingHighlights))
-                                throw new NotSupportedException("Multiple highlightings for the same field and group key are not supported.");
+                                throw new NotSupportedInCoraxException("Multiple highlightings for the same field and group key are not supported.");
 
                             tokensDictionary[key] = fragments.ToArray();
                         }
@@ -1270,9 +1270,9 @@ public override IEnumerable<BlittableJsonReaderObject> IndexEntries(IndexQuerySe
             var position = query.Start;
 
             if (query.Metadata.IsDistinct)
-                throw new NotSupportedException("We don't support Distinct in \"Show Raw Entry\" of Index.");
+                throw new NotSupportedInCoraxException("We don't support Distinct in \"Show Raw Entry\" of Index.");
             if (query.Metadata.FilterScript != null)
-                throw new NotSupportedException(
+                throw new NotSupportedInCoraxException(
                     "Filter isn't supported in Raw Index View.");
 
             var take = pageSize + position;

diff --git a/src/Raven.Server/Documents/Indexes/Persistence/Corax/CoraxQueryBuilder.cs b/src/Raven.Server/Documents/Indexes/Persistence/Corax/CoraxQueryBuilder.cs
@@ -11,6 +11,7 @@
 using Corax.Queries.SortingMatches.Meta;
 using Corax.Utils;
 using Raven.Client.Exceptions;
+using Raven.Client.Exceptions.Corax;
 using Raven.Server.Documents.Indexes.Persistence.Corax.QueryOptimizer;
 using Raven.Server.Documents.Queries;
 using Raven.Server.Documents.Queries.AST;
@@ -1037,7 +1038,7 @@ private static IQueryMatch HandleSearch(Parameters builderParameters, MethodExpr
 
         if (proximity.HasValue)
         {
-            throw new NotSupportedException($"{nameof(Corax)} doesn't support proximity over search() method");
+            throw new NotSupportedInCoraxException($"{nameof(Corax)} doesn't support proximity over search() method");
         }
 
         CoraxConstants.Search.Operator @operator = CoraxConstants.Search.Operator.Or;
@@ -1359,7 +1360,7 @@ spatialField.Units is SpatialUnits.Kilometers
             switch (orderingType)
             {
                 case OrderByFieldType.Custom:
-                    throw new NotSupportedException($"{nameof(Corax)} doesn't support Custom OrderBy.");
+                    throw new NotSupportedInCoraxException($"{nameof(Corax)} doesn't support Custom OrderBy.");
                 case OrderByFieldType.AlphaNumeric:
                     sortArray[sortIndex++] = new OrderMetadata(metadataField, field.Ascending, MatchCompareFieldType.Alphanumeric);
                     continue;