RavenDB-19578 Provide copy button in error dialogs

arekpalinski · Jun 25, 2024 · bf79035 · bf79035
1 parent 28c5107
commit bf79035
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/...Studio/typescript/viewmodels/common/notificationCenter/detailViewer/recentErrorDetails.ts b/...Studio/typescript/viewmodels/common/notificationCenter/detailViewer/recentErrorDetails.ts
@@ -3,6 +3,7 @@ import abstractNotification = require("common/notifications/models/abstractNotif
 import notificationCenter = require("common/notifications/notificationCenter");
 import recentError = require("common/notifications/models/recentError");
 import dialogViewModelBase = require("viewmodels/dialogViewModelBase");
+import copyToClipboard from "common/copyToClipboard";
 
 class recentErrorDetails extends dialogViewModelBase {
 
@@ -13,7 +14,7 @@ class recentErrorDetails extends dialogViewModelBase {
 
     constructor(recentError: recentError, notificationCenter: notificationCenter) {
         super();
-        this.bindToCurrentInstance("close", "dismiss");
+        this.bindToCurrentInstance("close", "dismiss", "copyErrorDetails");
 
         this.recentError = recentError;
         this.dismissFunction = () => notificationCenter.dismiss(recentError);
@@ -24,6 +25,11 @@ class recentErrorDetails extends dialogViewModelBase {
         this.close();
     }
 
+    copyErrorDetails(): void {
+        const errorDetails = this.recentError.details();
+        copyToClipboard.copy(errorDetails, "Error has been copied to clipboard");
+    }
+
     static supportsDetailsFor(notification: abstractNotification) {
         return notification instanceof recentError;
     }

diff --git a/...n.Studio/wwwroot/App/views/common/notificationCenter/detailViewer/recentErrorDetails.html b/...n.Studio/wwwroot/App/views/common/notificationCenter/detailViewer/recentErrorDetails.html
@@ -11,7 +11,13 @@ <h3 class="modal-title" id="myModalLabel" data-bind="text: title, attr: { class:
         </div>
         <div class="modal-body" data-bind="with: recentError">
             <div data-bind="html: longerMessage"></div>
-            <pre class="margin-top error-messages" data-bind="visible: details"><code data-bind="text: details"></code></pre>
+            <div class="d-flex margin-top" data-bind="visible: details">
+                <div class="flex-grow"></div>
+                <button class="btn btn-default btn-sm" data-bind="click: $parent.copyErrorDetails"><i class="icon-copy-to-clipboard"></i><span>Copy error message</span></button>
+            </div>
+            <pre class="d-flex error-messages position-relative" data-bind="visible: details">
+                <code data-bind="text: details"></code>
+            </pre>
         </div>
         <div class="modal-footer">
             <div class="flex-horizontal">