Add Travis CI YML description #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arekinath
reviewed
Oct 17, 2017
.travis.yml
Outdated
| - unzip java_card_kit-2_2_2-linux.zip | ||
| - cd java_card_kit-2_2_2/ | ||
| - unzip java_card_kit-2_2_2-rr-bin-linux-do.zip | ||
| - CLASSPATH=$CLASSPATH:$JC_HOME/lib |
There was a problem hiding this comment.
Is this CLASSPATH setting actually needed? I thought ant-javacard handled it.
|
I could remove it and see if the CAP still compiles just fine…
From: Alex Wilson
Sent: Monday, October 16, 2017 18:29
To: arekinath/PivApplet
Cc: Jeff Leung; Author
Subject: Re: [arekinath/PivApplet] Add Travis CI YML description (#1)
@arekinath commented on this pull request.
In .travis.yml:
@@ -0,0 +1,21 @@
+language: java
+
+env:
+ - JC_HOME=$TRAVIS_BUILD_DIR/jckit/java_card_kit-2_2_2
+
+before_script:
+ - git submodule init
+ - git submodule update
+ - mkdir jckit
+ - cd jckit
+ - "[ -f java_card_kit-2_2_2-linux.zip ] || curl -L http://download.oracle.com/otn-pub/java/java_card_kit/2.2.2/java_card_kit-2_2_2-linux.zip -o java_card_kit-2_2_2-linux.zip --cookie oraclelicense=accept-securebackup-cookie"
+ - unzip java_card_kit-2_2_2-linux.zip
+ - cd java_card_kit-2_2_2/
+ - unzip java_card_kit-2_2_2-rr-bin-linux-do.zip
+ - CLASSPATH=$CLASSPATH:$JC_HOME/lib
Is this CLASSPATH setting actually needed? I thought ant-javacard handled it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Yep, removing it has no effect on the build process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the PIVApplet builds successfully every time a change is pushed out to GitHub