Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquisition mode fallback #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

daykin
Copy link

@daykin daykin commented Apr 7, 2023

Fix for areaDetector/ADAravis#20:

Some of our beamline cameras (Imaging source DMK 33GX174) exclusively support continuous acquisition mode. I propose adding some "reasonable" fallback logic summarized as follows:

If user selects 'Single' and it's not supported, try 'multiple' (with the assumption you can just set nImages to 1).
If multiple is also not available, go to continuous.

If user selects 'Multiple' and it isn't available, go to continuous.

Otherwise (user picked 'continuous' or all mAcquisitionMode's are broken for whatever reason), go to continuous.

Also trimmed trailing whitespace from the entire file.

@MarkRivers I only have a 33GX174 to test with. Do you have a camera capable of all three modes to make sure it still works?

@daykin
Copy link
Author

daykin commented Apr 7, 2023

P.S. I also re-formatted this method to the clang-format style. Let me know if you'd like me to use a different formatting standard.

@MarkRivers
Copy link
Member

I neglected to merge this before I started using a camera with the same issue, it does not support Single mode.

I think the driver now handles cameras that don't support Single or Multiple. Please test it, and if it works I will close this PR.

In the future please separate PRs with functional changes from those with formatting changes. It makes it much easier to see what the significant changes are.

@daykin
Copy link
Author

daykin commented Jul 31, 2024

I am still getting the following with our camera that doesn't support single/multiple, on version 1.10:

** (process:3168344): CRITICAL **: 12:28:25.040: arv_gc_integer_get_value: assertion 'error == NULL || *error == NULL' failed
2024/07/31 12:28:25.572 ADAravis:processBuffer: w: 1440, h: 1080, size: 0, expected_size: 3110400

It is not critical for us at least.

@MarkRivers
Copy link
Member

Can you send a screenshot of the ADAravis screen and the camera-specific screen that shows the AcquisitionMode feature when this problem occurs?

@daykin
Copy link
Author

daykin commented Aug 1, 2024

image

image

'Acquisition mode' in the features page seems to behave correctly, in that there's only one option. The ADAravis main page 'Image Mode' still has options for single/multi/continuous with a valid readback reflecting that selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants