-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 8 and PHP 8 support #740
Conversation
@ifox What about Dependency tree (short):
Dependency tree (full):
|
You're right. I found this issue Azure/azure-storage-php#248 which doesn't seem like a priority in the repo. I think we need to consider moving to an optional dependency, but I assume that would mean bumping our major version as this would be a breaking change for anyone using Azure storage on Twill currently. Or we could fork Microsoft's package, but it seems like they are worried about Guzzle breaking changes themselves, so not sure if that's a good idea to undertake on our end. |
As a temporary solution, moving |
Hello! Any updates on this pull request? Thank you |
we are still waiting for Azure/azure-storage-php#248. I saw that they placed it on the November milestone, so this can take another 2 to 5 weeks. In the mean time, if you absolutely require this version and do not rely on Guzzle 7 specific features: just try dropping your Guzzle Requirement, and install this branch. |
@ifox Azure/azure-storage-php#248. The MR has been merged/closed. Looks like everything is ready now. How fast Twill 2.2 can be released? |
Finally! We still need a tagged release from them, but as soon as it's up I will be more than happy to update this PR and release. |
@ifox They released the new version of |
imagick hasn't been released on PECL for PHP 8 yet
Enable identifiers column (PK) to be overwritten by another name
@ifox is there any chance getting a version taged to be able to update to laravel 8? |
@ifox how can we help to get Twill 2.2 with Laravel 8 support to be released? Is there anything missing? |
Once all our dependencies release a new version supporting Laravel 8, Twill 2.2 will be released.
The remaining dependencies we need an update from are:
https://github.com/cartalyst/tags, where I opened a PR: Laravel 8 support cartalyst/tags#38https://github.com/lazychaser/laravel-nestedset, where a PR has already been opened: Add support for Laravel 8 lazychaser/laravel-nestedset#472.