Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Laravel 6.3 installation #428

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Conversation

antonioribeiro
Copy link
Member

This is what I was getting when trying to install on a fresh Laravel 6.3 app:

image

@ifox
Copy link
Member

ifox commented Oct 17, 2019

@antonioribeiro should we allow installing with any version of Laravel above 6.0 instead? I feel like some users might try installing on a recent project they have, but before updating their Laravel version

@antonioribeiro
Copy link
Member Author

antonioribeiro commented Oct 17, 2019

@ifox That's actually what it does, but everything >= 6.3. So 6.3.1 and 6.4 will be installed

@ifox
Copy link
Member

ifox commented Oct 17, 2019

Yup, got it. My point is that someone might be on Laravel 6.1 when they first try to install Twill.

@antonioribeiro
Copy link
Member Author

Yup, got it. My point is that someone might be on Laravel 6.1 when they first try to install Twill.

It's only a problem if the person sets its composer.json as

"laravel/framework": "6.1.*",

But this way they won't get any fixes and improvements, not sure if it makes sense while installing a new package like Twill.

If they leave it in the default:

"laravel/framework": "^6.2",

Composer will update both Laravel (to 6.3.x) and install Twill.

@ifox
Copy link
Member

ifox commented Oct 17, 2019

You're right, that makes sense. Thank you!

@ifox ifox merged commit ad92fbf into area17:master Oct 17, 2019
ferpetrelli pushed a commit to ferpetrelli/twill that referenced this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants