-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated Browser and Repeater Fields #400
Merged
ifox
merged 11 commits into
area17:1.2
from
yanhao-li:feature/automated-browsers-repeaters
Nov 19, 2019
Merged
Automated Browser and Repeater Fields #400
ifox
merged 11 commits into
area17:1.2
from
yanhao-li:feature/automated-browsers-repeaters
Nov 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifox
requested changes
Sep 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yanhao-li!
Amazing, this is looking great.
I have 1 discussion point and 1 change request:
- discussion: should the
browsers
andrepeaters
array be provided in the repository instead of the model? I would be in favor of the repository as I feel like the model should stay agnostic regarding that. - change request: this automation should also take care of hydrating the model for previews using
hydrateBrowser
andhydrateRepeater
.
@ifox Just pushed two commits to fix the things you mentioned. |
This will be deprecated in a future release.
This was referenced Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAY GOODBYE TO THE LONG-WINDED
updateBrowser
,getFormFieldsForBrowser
,updateRepeater
getFormFieldsForRepeater
IN YOUR REPOSITORY!Before:
After:
Changelog
$browsers
,$repeaters
. Avoid the extra setup by simply providing the module name, also support extra parameters as array.HandleBrowsers
model.stub
to include the two new attributes.