-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/i18n permalinks #1092
Feature/i18n permalinks #1092
Conversation
Nice to see somebody tackle this! To follow the way other Twill features are handled, the localized permalinks should probably be supplied through a method on the controller, similar to the original |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MamlukiSn, this is cool! I believe it's the final missing piece for fully configurable permalinks in TitleEditor
.
I've added a few questions and comments below.
Add localized permalinkbase trailing slashes in the frontend. Provide fallback for undefined locales in getLocalizedPermalinkBase().
Description
This PR enables the translation of permalinks.
Useful when frontend URL's are also translated based on the locale.
Usage