Partial dockerize development environment#11
Merged
Conversation
Member
Author
|
Hello @mrdoinel @ifox, the only biggest change in this PR is the usage of Still far from ideal scenario (mix of docker container for PHP and native Node for building the theme), but seems to be working properly. Looking forward your comments. |
This file should be ignored and instead `.htaccess` needs to be created from `htaccess` one. Update the later to ensure has all the right settings.
- Lock down version of node (LTS) - Avoid global installation of packages - Use `yarn` and lock dependencies with it
YAML uses 2 spaces, correct the included samples to avoid possible issues.
This builds a basic PHP 5.6 image with Apache and copies over the engine and themes within the image. Via composer, it allow mounting configuration and files from your local setup in order to test the application.
luislavena
force-pushed
the
feature/dockerize-development
branch
from
d757eed to
b754700
Compare
Member
|
This is great thanks @luislavena! The only thing I noticed is that the generated css is missing some browser prefixes but most are most likely not needed anymore and it is probably because the updated autoprefixer dependency has updated rules, right? |
Member
Author
Contributor
|
Yeah this is fine : we dont need webkit prefix anymore for the CSS animations (since at least version 9). |
Member
Author
ifox
approved these changes
Mar 5, 2020
mrdoinel
approved these changes
Mar 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aim to simplify local development:
Requirements:
Usage:
docker-compose build webdocker-compose up webdocker-compose downfrom another terminal windowyarn installgrunt initandgrunt buildwithyarn run grunt:initandyarn run grunt:buildrespectively./cc @mubashariqbal @mrdoinel