Skip to content

Add official Microsoft Azure SDK for C Arduino library. #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

ewertons
Copy link
Contributor

@ewertons ewertons commented Dec 6, 2021

From the library repo https://github.com/Azure/azure-sdk-for-c-arduino.

This new library maps to the new Azure SDK for C that is designed for
embedded development, published on
https://github.com/azure/azure-sdk-for-c.

This new azure-sdk-for-c-arduino library shall be prefered over the previous azure-iot-arduino
library and dependencies (azure-iot-arduino-utility,
azure-iot-arduino-protocol-http, azure-iot-arduino-protocol-mqtt,
azure-iot-arduino-socket-esp32-wifi).

For questions, please refer to maintainer of library.

From the library repo https://github.com/Azure/azure-sdk-for-c-arduino.

This new library maps to the new Azure SDK for C that is designed for
embedded development, published on
https://github.com/azure/azure-sdk-for-c.

This new azure-sdk-for-c-arduino library shall be prefered over the previous azure-iot-arduino
library and dependencies (azure-iot-arduino-utility,
azure-iot-arduino-protocol-http, azure-iot-arduino-protocol-mqtt,
azure-iot-arduino-socket-esp32-wifi).

For questions, please refer to maintainer of library.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

A problem was found with your submission https://github.com/Azure/azure-sdk-for-c-arduino

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

Thanks for your interest in contributing to the Arduino Library Manager index @ewertons
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@ewertons
Copy link
Contributor Author

ewertons commented Dec 6, 2021

To: @ArduinoBot

Fixed issues as recommended.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

Arduino Lint has suggestions for possible improvements to https://github.com/Azure/azure-sdk-for-c-arduino:

Linting library in azure-sdk-for-c-arduino
INFO: No header file found matching library name (Azure_SDK_for_C.h). Best practices are for primary header filename to 
      match library name. (Rule LS008)                                                                                  
WARNING: library.properties name Azure SDK for C contains spaces. Although supported, best practices is to not use      
         spaces. (Rule LP015)                                                                                           
WARNING: library.properties maintainer value Microsoft Azure IoT <aziotarduino@microsoft.com> contains "Arduino". 3rd   
         party libraries are not maintained by Arduino. (Rule LP057)                                                    

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in azure-sdk-for-c-arduino/examples/Azure_IoT_Hub_ESP32

Linter results for project: no errors or warnings

-------------------

Linting sketch in azure-sdk-for-c-arduino/examples/Azure_IoT_Hub_ESP8266

Linter results for project: no errors or warnings

-------------------

Linting sketch in azure-sdk-for-c-arduino/examples/Azure_IoT_Hub_RealtekAmebaD

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit a8ea8e8 into arduino:main Dec 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/Azure/azure-sdk-for-c-arduino/

github-actions bot pushed a commit that referenced this pull request Dec 6, 2021
@ewertons ewertons deleted the ewertons/msftazuresdk branch December 6, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant