Skip to content

Updated SSD1306 OLED Library's URL #6059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

styropyr0
Copy link
Contributor

I have my library's URL changed from https://github.com/styropyr0/oled.h to https://github.com/styropyr0/SSD1306. Please approve the changes or if there are things that need correction, please let me know.

Copy link
Contributor

Hi @styropyr0.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Mar 15, 2025
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/styropyr0/SSD1306:

Linting library in SSD1306
INFO: No header file found matching library name (SSD1306_OLED_Display.h). Best practices are for primary header        
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name SSD1306 OLED Display contains spaces. Although supported, best practices is to not use 
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in SSD1306/examples/Fragments

Linter results for project: no errors or warnings

-------------------

Linting sketch in SSD1306/examples/Fragments 1
ERROR: Prohibited character(s) in file name(s): Fragments 1.ino                                        
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)                                                                                    

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in SSD1306/examples/Hello World
WARNING: Sketch file/folder name mismatch. The primary sketch file name must match the folder: Hello World.ino
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#primary-sketch-file          
         (Rule SS001)                                                                                         

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in SSD1306/examples/Power Modes
WARNING: Sketch file/folder name mismatch. The primary sketch file name must match the folder: Power Modes.ino
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#primary-sketch-file          
         (Rule SS001)                                                                                         

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in SSD1306/examples/Shapes

Linter results for project: no errors or warnings

-------------------

Linting sketch in SSD1306/examples/Text

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 4 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @styropyr0
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 March 15, 2025 22:58
@styropyr0
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the request for review from per1234 March 15, 2025 23:00
Copy link
Contributor

Hi @styropyr0.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

A problem was found with your submission https://github.com/styropyr0/SSD1306

ERROR: Submission URL is already in the Library Manager index.

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @styropyr0
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 March 15, 2025 23:00
@styropyr0 styropyr0 closed this Mar 15, 2025
@per1234 per1234 self-assigned this Mar 16, 2025
@per1234 per1234 added topic: URL change Change library repository URL and removed topic: modification Change existing list entry labels Mar 16, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have my library's URL changed from https://github.com/styropyr0/oled.h to https://github.com/styropyr0/SSD1306.

This is false. It seems to be the very opposite. If I open this URL in my browser:

https://github.com/styropyr0/SSD1306

It is redirected to this URL:

https://github.com/styropyr0/oled.h

GitHub automatically sets up a redirect when you change a repository's name, so this tells me that you changed the repository name from "SSD1306" to "oled.h".

The bot resolves the URL from your pull request before checking for duplicates. So even though you used the URL https://github.com/styropyr0/SSD1306 in your pull request, the bot checks for existing registrations of the true URL https://github.com/styropyr0/oled.h. So this is why it returned the error:

❌ ERROR: Submission URL is already in the Library Manager index.

If you want to rename your repository, that is fine and we are happy to update the registration for the library. But you need to actually rename the repository before you submit the URL change request here.

@styropyr0 in the future please only create one PR for each request.

You will not accomplish anything by submitting the pull request multiple times. That will only waste your time and the time of the humans who maintain this free open source project.

If you have any questions, concerns, or problems, you are welcome to write a clear and detailed request in a comment here. I'll be happy to provide assistance.

⚠ Repeated irresponsible behavior may result in the revocation of your Library Manager Registry privileges.

Thanks in advance for your cooperation.


If you have any questions, concerns, or problems, you are welcome to write a clear and detailed description in a comment on the pull request thread. I'll be happy to provide assistance.

@styropyr0
Copy link
Contributor Author

styropyr0 commented Mar 16, 2025

Sorry for making things complicated. I have updated my repo's url to the one I was trying to add but the linter repeatedly gave me errors after fixing the following issue-

  1. Change the example file's name from Fragments 1.ino as it contains a whitespace.

This issue was resolved and updated in the main branch, but it was still raising the error. At that point, I just needed more time to look into the issue. I wasn't sure about what has went wrong. Since, it was raising error even after the fix, i closed the PR and reverted the url back to the original one.

@per1234
Copy link
Contributor

per1234 commented Mar 16, 2025

Thanks for the clarification.

This issue was resolved and updated in the main branch, but it was still raising the error.

Library Manager works exclusively from Git tags, so the bot will only see fixes you make after you create a new release or tag in the library repository.

So my hypothesis is that, at the time the error was being raised, the fix was not present in the latest tagged point in the repository's revision history.

From a quick look, it appears the problem is fixed in the v1.0.3 tag, so I think everything is good now.

@styropyr0
Copy link
Contributor Author

That makes sense. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants