Adjust placeholder location to gracefully handle non-replacement #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to crediting the contributor, this could be useful in a case where it is necessary to make adjustments to the template content, or for review of a proposed change.
The "Moved to Nederlands category" post template contains a placeholder which the template user should replace with a username mention at the time of posting. The template user might forget to make this replacement. The placeholder is in the form of an HTML comment tag, so will simply not be rendered in the published post if this occurs. With the previous placement of the placeholder at the start of a sentence, the published post would have an obviously incorrect form. By moving the placeholder to the end of the sentence, this eventually is mitigated down to only a single excess space in the published post. The new sentence form is grammatically valid and approximately equivalent to the previous form.
per1234
added
type: enhancement
per1234
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Moved to Nederlands category" post template contains a placeholder which the template user should replace with a username mention at the time of posting.
The template user might forget to make this replacement. The placeholder is in the form of an HTML comment tag, so will simply not be rendered in the published post if this occurs. With the previous placement of the placeholder at the start of a sentence, the published post would have an obviously incorrect form. By moving the placeholder to the end of the sentence, this eventually is mitigated down to only a single excess space in the published post.
The new sentence form is grammatically valid and approximately equivalent to the previous form.
Translation contributed by @sterretjeToo (thanks!)