Skip to content

Added container info and foundries information #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 9, 2023

Conversation

jcarolinares
Copy link
Contributor

What This PR Changes

  • Proposal for the BU to improve the information inside the Portenta X8

Contribution Guidelines

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 1, 2023

✅ docs-content deploy preview ready

@jcarolinares
Copy link
Contributor Author

Hey @martab1994 taking into account the implications of this PR related to the Portenta X8 I think it should be great to have your check

A reminder of the changes:

image

Copy link
Contributor

@martab1994 martab1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small rephrase please!

@jcarolinares
Copy link
Contributor Author

jcarolinares commented Feb 9, 2023

Hey @martab1994 I think this is ready for rocking.

Suggestions made sense and improved the meaning, so all of then have been accepted. Please take a look at the preview and approve the review and I will merge, thank you!

Copy link
Contributor

@martab1994 martab1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect for me, thanks!

@jcarolinares jcarolinares merged commit 604e89b into main Feb 9, 2023
@jcarolinares jcarolinares deleted the jcarolinares/portentax8/foundries-warning branch February 9, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants