Skip to content

Use most appropriate function for checking URL #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use most appropriate function for checking URL
From the http.Get() documentation:

> Caller should close resp.Body when done reading from it.

This was not done previously. Since the body is not needed, http.Head() is more appropriate for this application and it
does not impose the requirement to add additional code to clean up.
  • Loading branch information
per1234 committed Jun 7, 2021
commit 3adc4128b68e91994c6b6d9190faa88e02ca9f55
2 changes: 1 addition & 1 deletion internal/rule/rulefunction/library.go
Original file line number Diff line number Diff line change
Expand Up @@ -1011,7 +1011,7 @@ func LibraryPropertiesUrlFieldDeadLink() (result ruleresult.Type, output string)
}

logrus.Tracef("Checking URL: %s", url)
httpResponse, err := http.Get(url)
httpResponse, err := http.Head(url)
if err != nil {
return ruleresult.Fail, err.Error()
}
Expand Down
2 changes: 1 addition & 1 deletion internal/rule/rulefunction/library_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ func TestLibraryPropertiesUrlFieldDeadLink(t *testing.T) {
testTables := []libraryRuleFunctionTestTable{
{"Unable to load", "InvalidLibraryProperties", ruleresult.NotRun, ""},
{"Not defined", "MissingFields", ruleresult.NotRun, ""},
{"Bad URL", "BadURL", ruleresult.Fail, "^Get \"http://invalid/\": dial tcp: lookup invalid:"},
{"Bad URL", "BadURL", ruleresult.Fail, "^Head \"http://invalid/\": dial tcp: lookup invalid:"},
{"HTTP error 404", "URL404", ruleresult.Fail, "^404 Not Found$"},
{"Good URL", "Recursive", ruleresult.Pass, ""},
}
Expand Down