Skip to content

Abort rather than calling arduino-cli compile with a blank --fqbn #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Abort rather than calling arduino-cli compile with a blank --fqbn #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ls/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"context"
"fmt"
"io"
"log"
"strings"
"sync"
"time"
Expand Down Expand Up @@ -186,6 +187,12 @@ func (ls *INOLanguageServer) generateBuildEnvironment(ctx context.Context, fullB
ls.readLock(logger, false)
sketchRoot := ls.sketchRoot
config := ls.config

// Validate FQBN before attempting compilation
if config.Fqbn == "" {
ls.readUnlock(logger)
log.Fatal("FQBN (Fully Qualified Board Name) is required but not specified. Please restart the language server with the -fqbn flag or set default_fqbn in sketch.yaml")
}
type overridesFile struct {
Overrides map[string]string `json:"overrides"`
}
Expand Down
Loading