Skip to content

fix: restore window.titleBarStyle and breadcrumbs.enabled #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: restore window.titleBarStyle and breadcrumbs.enabled #1870

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ffe421
fix: restored `window.titleBarStyle`
Feb 9, 2023
88cd571
fix: restored `breadcrumbs.enabled`
Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: restored breadcrumbs.enabled 
Ref: #1733
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
  • Loading branch information
Akos Kitta committed Feb 15, 2023
commit 88cd571080a2f3c9e9c3eee1c8439b9c60c82c79
5 changes: 0 additions & 5 deletions arduino-ide-extension/src/browser/theia/core/tab-bars.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ export class TabBarRenderer extends TheiaTabBarRenderer {
}

export class ToolbarAwareTabBar extends TheiaToolbarAwareTabBar {
protected override async updateBreadcrumbs(): Promise<void> {
// NOOP
// IDE2 does not use breadcrumbs.
}

private readonly doUpdateToolbar = debounce(() => super.updateToolbar(), 500);
protected override updateToolbar(): void {
// Unlike Theia, IDE2 debounces the toolbar updates with 500ms
Expand Down